Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a --target parameter to uninstall to allow uninstalling from custom folders #1912

Closed
wants to merge 3 commits into from

Conversation

mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Jul 1, 2014

Essentially what it says on the tin. It adds a --target parameter that allows pip uninstall to uninstall from a specific folder instead of the site packages.

This is necessary for pips installed into a virtualenv as otherwise the virtualenv containment check prevents a deinstallation. It also is a bit safer because it will not uninstall from outside.

@Ivoz
Copy link
Contributor

Ivoz commented Jul 1, 2014

as otherwise the virtualenv containment check prevents a deinstallation

Can you explain what you exactly mean by this? Or otherwise, perhaps give specific detail of the practical use case that motivates this PR? You want to uninstall things outside a virtualenv with a pip inside a virtualenv?

@mitsuhiko
Copy link
Contributor Author

Currently there is no way to uninstall something installed via --target unless you use a globally installed pip because of the restrictions of pip in virtualenvs. That restriction makes sense and I do not advocate for removing it and instead have a separate flag on uninstall that can uninstall from a specific folder.

As of why this is useful: I want to use pip for plugin installations and install plugins into a local folder that only by the application is added to the pythonpath.

@webmaven
Copy link

On a related note, right now installations to a target folder have multiple problems ( #1489, #1636, #1710, #1818, #1833).

@webmaven
Copy link

@dstufft this looks like it could use some attention too.

@webmaven
Copy link

webmaven commented Sep 3, 2014

@pfmoore @jonparrott This looks like a good next candidate for merging, if the conflicts are resolved.

@msabramo
Copy link
Contributor

@mitsuhiko: Want to update this?

@dstufft dstufft closed this May 18, 2016
@dstufft
Copy link
Member

dstufft commented May 18, 2016

Accidentally closed this, reopening. Sorry!

@dstufft dstufft reopened this May 18, 2016
@BrownTruck
Copy link
Contributor

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

Essentially what it says on the tin.  It adds a --target parameter that allows pip uninstall to uninstall from a specific folder instead of the site packages.

This is necessary for pips installed into a virtualenv as otherwise the virtualenv containment check prevents a deinstallation.  It also is a bit safer because it will not uninstall from outside.

---

*This was migrated from pypa/pip#1912 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@webmaven
Copy link

webmaven commented May 22, 2016

@mitsuhiko, can you reparent this PR as requested?

@BrownTruck BrownTruck added the auto-bitrotten PRs that died because they weren't updated label May 26, 2016
@BrownTruck
Copy link
Contributor

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

@webmaven
Copy link

:-(

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-bitrotten PRs that died because they weren't updated auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants